[all-commits] [llvm/llvm-project] f54dc7: [mlir][ODS] Omit printing default-valued attribute...

[Benjamin Maxwell via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f54dc7b3936f1bd751db710cfc2fec1652159a3f
      https://github.com/llvm/llvm-project/commit/f54dc7b3936f1bd751db710cfc2fec1652159a3f
  Author: Benjamin Maxwell <benjamin.maxwell at arm.com>
  Date:   2023-10-13 (Fri, 13 Oct 2023)

  Changed paths:
    M flang/test/Lower/OpenMP/FIR/atomic-read.f90
    M flang/test/Lower/OpenMP/FIR/critical.f90
    M flang/test/Lower/OpenMP/critical.f90
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir
    M mlir/test/python/dialects/transform_structured_ext.py
    M mlir/test/python/dialects/transform_vector_ext.py
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][ODS] Omit printing default-valued attributes in oilists (#68880)

This makes these match the behaviour of optional attributes (which are
omitted when they are their default value of none). This allows for
concise assembly formats without a custom printer.

An extra print of " " is also removed, this does change any existing
uses of oilists, but if the parameter before the oilist is optional,
that would previously add an extra space.

This #68694 + some fixes for the MLIR Python tests, unfortunately GitHub
does not allow re-opening PRs :confused: