[all-commits] [llvm/llvm-project] e98a4b: [mlir][ODS] Omit printing default-valued attribute...

Benjamin Maxwell via All-commits all-commits at lists.llvm.org
Thu Oct 12 04:26:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e98a4bb00d55504d6630327bcea62eca183d1f16
      https://github.com/llvm/llvm-project/commit/e98a4bb00d55504d6630327bcea62eca183d1f16
  Author: Benjamin Maxwell <benjamin.maxwell at arm.com>
  Date:   2023-10-12 (Thu, 12 Oct 2023)

  Changed paths:
    M flang/test/Lower/OpenMP/FIR/atomic-read.f90
    M flang/test/Lower/OpenMP/FIR/critical.f90
    M flang/test/Lower/OpenMP/critical.f90
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][ODS] Omit printing default-valued attributes in oilists (#68694)

This makes these match the behaviour of optional attributes (which are
omitted when they are their default value of `none`). This allows for
concise assembly formats without a custom printer.

An extra print of " " is also removed, this does change any existing
uses of oilists, but if the parameter before the oilist is optional,
that would previously add an extra space.




More information about the All-commits mailing list