[all-commits] [llvm/llvm-project] 05181a: [libunwind] Fix wrong end argument passed to decod...

Alexander Richardson via All-commits all-commits at lists.llvm.org
Wed Oct 11 11:35:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 05181a849b4c1ec14fdd6d667285d6f5ad34a5a2
      https://github.com/llvm/llvm-project/commit/05181a849b4c1ec14fdd6d667285d6f5ad34a5a2
  Author: Alexander Richardson <alexrichardson at google.com>
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
    M libunwind/src/AddressSpace.hpp

  Log Message:
  -----------
  [libunwind] Fix wrong end argument passed to decodeEHHdr() (#68813)

All but one callsite were actually passing start+length arguments.
This should not have any functional change since the end argument is
almost always ignored.
I noticed this while debugging some incorrect error messages being
printed while running the testsuite baremetal (using binaries that did
not have a valid eh_frame_hdr section): the tests print
`libunwind: unsupported .eh_frame_hdr version: 20 at
https://github.com/arichardson/upstream-llvm-project/commit/8000d308146ebf49cb364cb600e28a0a42e22c83`
because
libunwind is reading nonsense data for .eh_frame_hdr.




More information about the All-commits mailing list