[all-commits] [llvm/llvm-project] 97b989: [compiler-rt] During profile flushing, setup SIGKI...

serge-sans-paille via All-commits all-commits at lists.llvm.org
Tue Oct 10 12:19:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 97b989b27496d5aeadb3b90cbb9305ddcd9e35d2
      https://github.com/llvm/llvm-project/commit/97b989b27496d5aeadb3b90cbb9305ddcd9e35d2
  Author: serge-sans-paille <serge.guelton at telecom-bretagne.eu>
  Date:   2023-10-10 (Tue, 10 Oct 2023)

  Changed paths:
    M compiler-rt/lib/profile/InstrProfilingFile.c

  Log Message:
  -----------
  [compiler-rt] During profile flushing, setup SIGKILL mask earlier (#68622)

In multi threaded application, it is possible for one thread to
terminate the program while another is flushing profile information. We
setup a signal mask to delay SIGKILL so that we can safely flush the
profile.

This patch setups the mask earlier: it reduces the window during which a
SIGKILL can end the computation prematurely.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1850940, where a
profiled firefox was encountering several:

LLVM Profile Error: Failed to write file "default_*.profraw": Broken
pipe

Co-authored-by: serge-sans-paille <sguelton at mozilla.com>




More information about the All-commits mailing list