[all-commits] [llvm/llvm-project] bc34a8: [ASan][Windows] Fix rip-relative instruction repla...

nicole mazzuca via All-commits all-commits at lists.llvm.org
Mon Oct 9 14:53:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc34a83380152e44fdb75ff7c66ab8f1970c4633
      https://github.com/llvm/llvm-project/commit/bc34a83380152e44fdb75ff7c66ab8f1970c4633
  Author: nicole mazzuca <nicole at strega-nil.co>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M compiler-rt/lib/interception/interception_win.cpp

  Log Message:
  -----------
  [ASan][Windows] Fix rip-relative instruction replacement (#68432)

The old code incorrectly checked what relative offsets were allowed.

The correct check is that the offset from the target to the instruction
pointer should be within $[-2^{31}, 2^{31})$; however, the check that
was originally written was that the offset was within $[0, 2^{31})$.
Negative offsets are certainly allowable (as long as they fit in 32
bits), and this change fixes that.




More information about the All-commits mailing list