[all-commits] [llvm/llvm-project] 5e3f43: [libcxx] [test] Quote the python executable in the...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Oct 9 13:19:19 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5e3f43e16ce741a48dee21ddc042c3811a7320ce
      https://github.com/llvm/llvm-project/commit/5e3f43e16ce741a48dee21ddc042c3811a7320ce
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M libcxx/utils/libcxx/test/params.py

  Log Message:
  -----------
  [libcxx] [test] Quote the python executable in the executor (#68208)

This reapplies the change from
c218c80c730a14a1cbcebd588b18220a879702c6, which was lost in the
refactoring in 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83.

On Windows, the Python interpreter is by default installed in a path
like "C:\Program Files\Python38\python.exe", which requires quoting when
included in a concatenated command string (as opposed to a command list,
where each argument is a separate element).

This doesn't show up in the CI environments as they use Python installed
in a different directory, like C:\Python.

In addition to the python executable, also quote the path to run.py, if
needed.




More information about the All-commits mailing list