[all-commits] [llvm/llvm-project] 2e8269: [lldb][NFCI] Remove use of ConstString from Filter...

[Alex Langford via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e8269690909ddeced2bb9dd783ff88bf179c246
      https://github.com/llvm/llvm-project/commit/2e8269690909ddeced2bb9dd783ff88bf179c246
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    M lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp

  Log Message:
  -----------
  [lldb][NFCI] Remove use of ConstString from FilterRule in StructuredDataDarwinLog (#68347)

There are only ever 2 FilterRules and their operations are either
"regex" or "match". This does not benefit from deduplication since the
strings have static lifetime and we can just compare StringRefs pointing
to them. This is also not on a fast path, so it doesn't really benefit
from the pointer comparisons of ConstStrings.