[all-commits] [llvm/llvm-project] 1d959f: [OpenMP] Prevent AMDGPU from overriding visibility...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d959f932752b39cd535cb22f043333e348a4b01
      https://github.com/llvm/llvm-project/commit/1d959f932752b39cd535cb22f043333e348a4b01
  Author: Joseph Huber <35342157+jhuber6 at users.noreply.github.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/CodeGen/Targets/AMDGPU.cpp
    M clang/test/OpenMP/declare_target_codegen.cpp
    M clang/test/OpenMP/declare_target_constexpr_codegen.cpp
    M clang/test/OpenMP/target_visibility.cpp

  Log Message:
  -----------
  [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (#68264)

Summary:
There's some logic in the AMDGPU target that manually resets the
requested visibility of certain variables. This was triggering when we
set a constant variable in OpenMP. However, we shouldn't do this for
OpenMP when the variable has the `nohost` type. That implies that the
variable is not visible to the host and therefore does not need to be
visible, so we should respect the original value of it.