[all-commits] [llvm/llvm-project] 7a46ba: ValueTracking: Use fcAllFlags for unknown value (#...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Oct 5 13:10:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4
      https://github.com/llvm/llvm-project/commit/7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M llvm/lib/Analysis/ValueTracking.cpp
    M llvm/unittests/Analysis/ValueTrackingTest.cpp

  Log Message:
  -----------
  ValueTracking: Use fcAllFlags for unknown value (#66393)

In the failure case we return null, which callers are checking. We were
also returning an fcNone which was unused. It's more consistent to
return fcAllFlags as any possible value, such that the value is always
directly usable without checking the returned value.




More information about the All-commits mailing list