[all-commits] [llvm/llvm-project] a50e63: Fixes and closes #53952. Setting the ASTHasCompile...

[Rajkumar Ananthu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a50e63b38b931d945f97eac882278068221eca17
      https://github.com/llvm/llvm-project/commit/a50e63b38b931d945f97eac882278068221eca17
  Author: Rajkumar Ananthu <rajkumar.ananthu108 at gmail.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Frontend/ASTUnit.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/GeneratePCH.cpp

  Log Message:
  -----------
  Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)

The issue #53952 is reported indicating clang is giving a crashing pch
file, when hasErrors is been passed incorrectly to WriteAST method.

To fix the issue, the parameter has been removed and instead we're
relying on the results of `hasUncompilableErrorOccured()` instead of
letting the caller override it.

Fixes https://github.com/llvm/llvm-project/issues/53952