[all-commits] [llvm/llvm-project] 7e2823: Reland "[HIP] Support compressing device binary"

Yaxun (Sam) Liu via All-commits all-commits at lists.llvm.org
Thu Oct 5 08:21:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7e2823438e920d25364ff92b62ad90020c31bb59
      https://github.com/llvm/llvm-project/commit/7e2823438e920d25364ff92b62ad90020c31bb59
  Author: Yaxun (Sam) Liu <yaxun.liu at amd.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M clang/docs/ClangOffloadBundler.rst
    M clang/include/clang/Driver/OffloadBundler.h
    M clang/include/clang/Driver/Options.td
    M clang/lib/Driver/OffloadBundler.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/HIPUtility.cpp
    A clang/test/Driver/clang-offload-bundler-zlib.c
    A clang/test/Driver/clang-offload-bundler-zstd.c
    A clang/test/Driver/hip-offload-compress-zlib.hip
    A clang/test/Driver/hip-offload-compress-zstd.hip
    M clang/tools/clang-offload-bundler/CMakeLists.txt
    M clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp
    M llvm/include/llvm/BinaryFormat/Magic.h
    M llvm/lib/BinaryFormat/Magic.cpp
    M llvm/lib/Object/Binary.cpp
    M llvm/lib/Object/ObjectFile.cpp

  Log Message:
  -----------
  Reland "[HIP] Support compressing device binary"

Original PR: https://github.com/llvm/llvm-project/pull/67162

The commit was reverted due to UB detected by santizer:

https://lab.llvm.org/buildbot/#/builders/238/builds/5955

clang/lib/Driver/OffloadBundler.cpp:1012:25: runtime error:
 load of misaligned address 0xaaaae2d90e7c for type
 'const uint64_t' (aka 'const unsigned long'), which
 requires 8 byte alignment

It was fixed by using memcpy instead of dereferencing int*
casted from unaligned char*.




More information about the All-commits mailing list