[all-commits] [llvm/llvm-project] e59942: [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_T...

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e5994229541bbe78c3e6eb548224b46f8c3c91be
      https://github.com/llvm/llvm-project/commit/e5994229541bbe78c3e6eb548224b46f8c3c91be
  Author: Alexander Richardson <alexrichardson at google.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M clang/cmake/caches/CrossWinToARMLinux.cmake
    M libcxx/test/CMakeLists.txt
    M libcxxabi/test/CMakeLists.txt
    M libunwind/test/CMakeLists.txt
    A runtimes/cmake/Modules/HandleLitArguments.cmake

  Log Message:
  -----------
  [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (#67691)

Since 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 the recommended way to
pass an executor is to use the _TEST_PARAMS variable, which means we now
pass more complicated value (including ones that may contain multiple
`=`) as part of this variable. However, the `REGEX REPLACE` being used
has greedy matches so everything up to the last = becomes part of the
variable name which results in invalid syntax in the generated lit
config file.

This was noticed due to builder failures for those using the
CrossWinToARMLinux.cmake cache file.

---------

Co-authored-by: Vladimir Vereschaka <vvereschaka at accesssoftek.com>