[all-commits] [llvm/llvm-project] 5fc28e: Improve MLIR Attribute::get() method efficiency by...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Tue Oct 3 18:07:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fc28e7a8d989fffafec2301529d0164a28799b2
      https://github.com/llvm/llvm-project/commit/5fc28e7a8d989fffafec2301529d0164a28799b2
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M mlir/include/mlir/IR/StorageUniquerSupport.h
    M mlir/include/mlir/Support/StorageUniquer.h
    M mlir/test/lib/Dialect/Test/TestAttrDefs.td
    M mlir/test/lib/Dialect/Test/TestAttributes.cpp
    M mlir/test/lib/Dialect/Test/TestAttributes.h
    M mlir/test/mlir-tblgen/attrdefs.td
    M mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
    M mlir/unittests/IR/AttributeTest.cpp

  Log Message:
  -----------
  Improve MLIR Attribute::get() method efficiency by reducing the amount of argument copies (#68067)

This ensures that the proper std::forward/std::move are involved, we go from 6
copy-constructions to 0 (!) on Attribute creation in release builds.




More information about the All-commits mailing list