[all-commits] [llvm/llvm-project] a6cdbb: [libcxx][test] Amend XFAIL directive in no_unique_...

Caslyn Tonelli via All-commits all-commits at lists.llvm.org
Tue Oct 3 17:16:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6cdbba4d68c9387e560c026320772d383be3d52
      https://github.com/llvm/llvm-project/commit/a6cdbba4d68c9387e560c026320772d383be3d52
  Author: Caslyn Tonelli <6718161+Caslyn at users.noreply.github.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M libcxx/test/libcxx/ranges/range.adaptors/range.lazy.split/no_unique_address.compile.pass.cpp
    M libcxx/test/libcxx/ranges/range.adaptors/range.split/no_unique_address.compile.pass.cpp
    M libcxx/test/libcxx/ranges/range.factories/range.istream.view/no_unique_address.compile.pass.cpp

  Log Message:
  -----------
  [libcxx][test] Amend XFAIL directive in no_unique_address tests (#67849)

This PR amends the `XFAIL` directive to clang < 18 in
no_unique_address.compile.pass.cpp tests.

Since PR 67199 implements the [[msvc::no_unique_address]] attribute,
these tests pass in a windows-x64 build against ToT clang-cl:

```
********************
Unexpectedly Passed Tests (3):
llvm-libc++-static-clangcl.cfg.in :: libcxx/ranges/range.adaptors/range.lazy.split/no_unique_address.compile.pass.cpp
llvm-libc++-static-clangcl.cfg.in :: libcxx/ranges/range.adaptors/range.split/no_unique_address.compile.pass.cpp
llvm-libc++-static-clangcl.cfg.in :: libcxx/ranges/range.factories/range.istream.view/no_unique_address.compile.pass.cpp
```

---------

Co-authored-by: Caslyn Tonelli <caslyn at google.com>




More information about the All-commits mailing list