[all-commits] [llvm/llvm-project] 27254a: [clang] NFCI: Use `FileEntryRef` for `FileID` crea...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27254ae51192d83fd45777cc33b004d06c2ceb50
      https://github.com/llvm/llvm-project/commit/27254ae51192d83fd45777cc33b004d06c2ceb50
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M clang-tools-extra/clang-change-namespace/tool/ClangChangeNamespace.cpp
    M clang-tools-extra/clang-move/Move.cpp
    M clang-tools-extra/clang-reorder-fields/tool/ClangReorderFields.cpp
    M clang-tools-extra/clang-tidy/ClangTidy.cpp
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
    M clang/include/clang/Basic/SourceManager.h
    M clang/lib/Basic/SourceManager.cpp
    M clang/lib/Tooling/Core/Replacement.cpp
    M clang/lib/Tooling/Refactoring.cpp
    M clang/tools/clang-rename/ClangRename.cpp
    M clang/unittests/Analysis/UnsafeBufferUsageTest.cpp

  Log Message:
  -----------
  [clang] NFCI: Use `FileEntryRef` for `FileID` creation (#67838)

This patch removes the `SourceManager` APIs that create `FileID` from a
`const FileEntry *` in favor of APIs that take `FileEntryRef`. This also
removes a misleading documentation that claims `nullptr` file entry
represents stdin. I don't think that's right, since we just try to
dereference that pointer anyways.