[all-commits] [llvm/llvm-project] 5064ca: [CodeExtractor] Consider Value arguments of dbg.as...

Felipe de Azevedo Piovezan via All-commits all-commits at lists.llvm.org
Tue Oct 3 09:55:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5064ca8b591315b628120f67de0411f8e20f2e8f
      https://github.com/llvm/llvm-project/commit/5064ca8b591315b628120f67de0411f8e20f2e8f
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M llvm/lib/Transforms/Utils/CodeExtractor.cpp
    A llvm/test/Transforms/HotColdSplit/invalid-dbg-assign.ll

  Log Message:
  -----------
  [CodeExtractor] Consider Value arguments of dbg.assign (#67987)

Currently, the code extractor functionality deletes a debug intrinsic if
its "Location" argument is not part of the extracted function. The
location is the first argument (or the first few arguments in case of a
DIArgList) of all debug intrinsics.

However, according to the docs, the signature of dbg.assign is:

```
void @llvm.dbg.assign(Value *Value,
                      DIExpression *ValueExpression,
                      DILocalVariable *Variable,
                      DIAssignID *ID,
                      Value *Address,
                      DIExpression *AddressExpression)
```

That is, there are two `Value` arguments to it: the usual location
argument and an "Address" argument. This Address argument should also
receive the same treatment.




More information about the All-commits mailing list