[all-commits] [llvm/llvm-project] a2ef04: [LLD][ELF] Import `ObjFile::importCmseSymbols` at ...
Alexandre Ganea via All-commits
all-commits at lists.llvm.org
Tue Oct 3 07:12:24 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: a2ef046a2d19eef297defa613d17283c46361fcb
https://github.com/llvm/llvm-project/commit/a2ef046a2d19eef297defa613d17283c46361fcb
Author: Alexandre Ganea <37383324+aganea at users.noreply.github.com>
Date: 2023-10-03 (Tue, 03 Oct 2023)
Changed paths:
M lld/ELF/InputFiles.cpp
M lld/ELF/InputFiles.h
Log Message:
-----------
[LLD][ELF] Import `ObjFile::importCmseSymbols` at call site (#68025)
Before this patch, with MSVC I was seeing:
```
[304/334] Building CXX object tools\lld\ELF\CMakeFiles\lldELF.dir\InputFiles.cpp.obj
C:\git\llvm-project\lld\ELF\InputFiles.h(327): warning C4661: 'void lld::elf::ObjFile<llvm::object::ELF32LE>::importCmseSymbols(void)': no suitable definition provided for explicit template instantiation request
C:\git\llvm-project\lld\ELF\InputFiles.h(291): note: see declaration of 'lld::elf::ObjFile<llvm::object::ELF32LE>::importCmseSymbols'
C:\git\llvm-project\lld\ELF\InputFiles.h(327): warning C4661: 'void lld::elf::ObjFile<llvm::object::ELF32LE>::redirectCmseSymbols(void)': no suitable definition provided for explicit template instantiation request
C:\git\llvm-project\lld\ELF\InputFiles.h(292): note: see declaration of 'lld::elf::ObjFile<llvm::object::ELF32LE>::redirectCmseSymbols'
```
This patch removes `redirectCmseSymbols` which is not defined. And it
imports `importCmseSymbols` in InputFiles.cpp, because it is already
explicitly instantiated in ARM.cpp.
More information about the All-commits
mailing list