[all-commits] [llvm/llvm-project] 3f0927: [C++20] [Modules] Fix crash when emitting module i...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Mon Oct 2 03:33:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f0927368285505ead516ba7572baaa7f52b01a9
      https://github.com/llvm/llvm-project/commit/3f0927368285505ead516ba7572baaa7f52b01a9
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M clang/lib/CodeGen/CGDeclCXX.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp
    A clang/test/Modules/module-init-duplicated-import.cppm
    A clang/test/Modules/pr67893.cppm

  Log Message:
  -----------
  [C++20] [Modules] Fix crash when emitting module inits for duplicated modules

Close https://github.com/llvm/llvm-project/issues/67893

The root cause of the crash is an oversight that we missed the point
that the same module can be imported multiple times. And we should use
`SmallSetVector` instead of `SmallVector` to filter the case.




More information about the All-commits mailing list