[all-commits] [llvm/llvm-project] 710b5a: Fix logic to detect cl::option equality. (#65754)

[Christian Sigg via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 710b5a12324e54d42632985c46a3071fc2504fc9
      https://github.com/llvm/llvm-project/commit/710b5a12324e54d42632985c46a3071fc2504fc9
  Author: Christian Sigg <chsigg at users.noreply.github.com>
  Date:   2023-09-10 (Sun, 10 Sep 2023)

  Changed paths:
    M llvm/include/llvm/Support/CommandLine.h
    M llvm/lib/Support/CommandLine.cpp
    M llvm/unittests/Support/CommandLineTest.cpp
    M mlir/test/Pass/pipeline-options-parsing.mlir
    M mlir/test/lib/Pass/TestPassManager.cpp

  Log Message:
  -----------
  Fix logic to detect cl::option equality. (#65754)

This is a new attempt of https://reviews.llvm.org/D159481, this time as
GitHub PR.

`GenericOptionValue::compare()` should return `true` for a match.

- `OptionValueBase::compare()` always returns `false` and shouldn't
match anything.
- `OptionValueCopy::compare()` returns `false` if not `Valid` which
corresponds to no match.

Also adding some tests.