[all-commits] [llvm/llvm-project] 140f61: [lldb][NFCI] Remove typedef for TypeCategoryMap::V...

[Alex via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 140f6167b885b4e0d6672a7f41c2b2b551c0204d
      https://github.com/llvm/llvm-project/commit/140f6167b885b4e0d6672a7f41c2b2b551c0204d
  Author: Alex <alangford at apple.com>
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
    M lldb/include/lldb/DataFormatters/FormatManager.h
    M lldb/include/lldb/DataFormatters/TypeCategoryMap.h
    M lldb/source/DataFormatters/TypeCategoryMap.cpp

  Log Message:
  -----------
  [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (#65555)

lldb already has a `ValueSP` type. This was confusing to me when reading
TypeCategoryMap, especially when `ValueSP` is not qualified. From first
glance it looks like it's referring to a
`std::shared_ptr<lldb_private::Value>` when it's really referring to a
`std::shared_ptr<lldb_private::TypeCategoryImpl>`.