[all-commits] [llvm/llvm-project] f5fc8b: [DebugInfo][NFC] Move ObjC Selector name handling ...

Felipe de Azevedo Piovezan via All-commits all-commits at lists.llvm.org
Thu Sep 7 07:13:35 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5fc8b6251726c6fe31e11f010271d446956dd54
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
    M llvm/lib/DWARFLinker/DWARFLinker.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
    M llvm/test/tools/dsymutil/X86/objc.test

  Log Message:
  [DebugInfo][NFC] Move ObjC Selector name handling to lib DebugInfo

The DWARFLinker library has code to identify ObjC selector names, which is used
by the debug linker to generate accelerator table entries. In the future, we
would like the DWARF verifier to also have access to such code, so that it can
identify these names when verifying accelerator tables (e.g. debug_names).

This patch follows the same intent of D155723, where we also moved code
generating simplified template names.

Since this is moving code around and changing the log, we also replace raw
pointer manipulation with the more expressive
StringRef::{drop_front,take_front,...} methods.

We also change a test so that it verifies its output, and that requires having
dsymutil not write to stdout.

Differential Revision: https://reviews.llvm.org/D158980

More information about the All-commits mailing list