[all-commits] [llvm/llvm-project] 6f3871: [libc] Fix failing mktime test case in 32-bit syst...

Mikhail R. Gadelha via All-commits all-commits at lists.llvm.org
Wed Sep 6 11:29:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6f387135ae9b25f761127b5cf6c04a06263d58b7
      https://github.com/llvm/llvm-project/commit/6f387135ae9b25f761127b5cf6c04a06263d58b7
  Author: Mikhail R. Gadelha <mikhail at igalia.com>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M libc/test/src/time/mktime_test.cpp

  Log Message:
  -----------
  [libc] Fix failing mktime test case in 32-bit systems (#65390)

Previously, these tests expected that calling mktime with a struct tm
that caused overlow to succeed with return -1
(TimeConstants::OUT_OF_RANGE_RETURN_VALUE), however, the Succeeds call
expects the errno to be zero (no failure).

This patch fixes the expected calls to fail with EOVERFLOW. These tests
are only enabled to 32-bit systems, and are probably not being tested on
the arm32 buildbot, that's why this was not a problem before.




More information about the All-commits mailing list