[all-commits] [llvm/llvm-project] 666098: [Headers] Remove musl-related comment about NULL

Heejin Ahn via All-commits all-commits at lists.llvm.org
Tue Sep 5 13:29:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 666098c5b3ea6e01ffe9e827064c26dfaaf9c655
      https://github.com/llvm/llvm-project/commit/666098c5b3ea6e01ffe9e827064c26dfaaf9c655
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M clang/lib/Headers/__stddef_null.h

  Log Message:
  -----------
  [Headers] Remove musl-related comment about NULL

This removes a comment added in D159312, which warned people to not
re-add a whitespace in the `((void*)0))` expression. After discussions
happened in D159312, it doesn't seem like a permanent solution.

While I'd like to keep the whitespace removed for now, given that at
least it can be a band-aid to some users who use musl and clang's
`stddef.h` at the same time, it seems the usage of them together is not
something that's officially supported, and I should not be implying this
should be the permanent solution by saying so in the comments.

Reviewed By: aaron.ballman, ributzka

Differential Revision: https://reviews.llvm.org/D159383




More information about the All-commits mailing list