[all-commits] [llvm/llvm-project] 19b44c: [lit] Echo full RUN lines in case of external shel...

[Joel E. Denny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19b44c2bdf1726acd380f76d26673a27ecf826ba
      https://github.com/llvm/llvm-project/commit/19b44c2bdf1726acd380f76d26673a27ecf826ba
  Author: Joel E. Denny <26551020+jdenny-ornl at users.noreply.github.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M llvm/utils/lit/lit/TestRunner.py
    A llvm/utils/lit/tests/Inputs/shtest-run-at-line/external-shell/empty-run-line.txt
    A llvm/utils/lit/tests/Inputs/shtest-run-at-line/internal-shell/empty-run-line.txt
    M llvm/utils/lit/tests/shtest-run-at-line.py

  Log Message:
  -----------
  [lit] Echo full RUN lines in case of external shells (#65267)

Before <https://reviews.llvm.org/D154984> and
<https://reviews.llvm.org/D156954>, lit reported full RUN lines in a
`Script:` section. Now, in the case of lit's internal shell, it's the
execution trace that includes them. However, if lit is configured to use
an external shell (e.g., bash, windows `cmd`), they aren't reported at
all.

A fix was requested at the following:

* <https://reviews.llvm.org/D154984#4627605>
*
<https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839/35?u=jdenny-ornl>

This patch does not correctly address the case when the external shell
is windows `cmd`. As discussed at
<https://github.com/llvm/llvm-project/pull/65242>, it's not clear
whether that's a use case that people still care about, and it seems to
be generally broken anyway.