[all-commits] [llvm/llvm-project] e22f04: [mlir][gpu] Fix option parsing in `TargetOptions`

Fabian Mora via All-commits all-commits at lists.llvm.org
Mon Sep 4 17:54:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e22f04b597e03339739d42e3a60c05634bb74313
      https://github.com/llvm/llvm-project/commit/e22f04b597e03339739d42e3a60c05634bb74313
  Author: Fabian Mora <fmora.dev at gmail.com>
  Date:   2023-09-04 (Mon, 04 Sep 2023)

  Changed paths:
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

  Log Message:
  -----------
  [mlir][gpu] Fix option parsing in `TargetOptions`

`TargetOptions` includes a field for passing additional command line options to
the GPU compilation process. This field is typically used during the 'gpu-module-to-binary`
pass:
```
--gpu-module-to-binary=opts="-v -c"
```

The problem is that `tokenizeCmdOptions` receives the quoted string, which produces an
incorrect tokenization for `"-v -c"`. This patch removes quotes, fixing this issue.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D159434




More information about the All-commits mailing list