[all-commits] [llvm/llvm-project] 9442b4: [mlir][linalg][transform][python] Fix optional arg...

Ingo Müller via All-commits all-commits at lists.llvm.org
Sat Sep 2 04:19:20 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9442b441c1c50e4e6782fd2e6aa16925c9d22e29
  Author: Ingo Müller <ingomueller at google.com>
  Date:   2023-09-02 (Sat, 02 Sep 2023)

  Changed paths:
    M mlir/python/mlir/dialects/_structured_transform_ops_ext.py
    M mlir/test/python/dialects/transform_structured_ext.py

  Log Message:
  [mlir][linalg][transform][python] Fix optional args of PadOp mix-in.

The mix-in did not allow to *not* set many of the arguments, even though
they represent optional attributes. Instead, it set default values,
which have different semantics in some cases. In other cases, setting
the default values is already done by the C++ layer, in which case they
are currently redundant and may be wrong in some potential future change
in the TD or C++ files. With this patch, `None` is preserved until the
generated binding, which handles them as desired.

Reviewed By: springerm

Differential Revision: https://reviews.llvm.org/D158844

More information about the All-commits mailing list