[all-commits] [llvm/llvm-project] 2fd01d: [clang] Construct ExprRequirement with Substitutio...

[zyn0217 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fd01d75a863184766ee0c82b5c0fc8be172448a
      https://github.com/llvm/llvm-project/commit/2fd01d75a863184766ee0c82b5c0fc8be172448a
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/AST/ExprConcepts.h
    M clang/lib/Sema/SemaExprCXX.cpp
    M clang/lib/Sema/SemaTemplateInstantiate.cpp
    A clang/test/SemaCXX/concept-crash-on-diagnostic.cpp
    M clang/test/SemaCXX/concept-fatal-error.cpp

  Log Message:
  -----------
  [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

We're expecting a SubstitutionDiagnostic in diagnoseUnsatisfiedRequirement
if the status of ExprRequirement is SubstFailure. Previously, the Requirement
was created with Expr on SubstFailure by mistake, which could lead to the
assertion failure in the subsequent diagnosis.

Fixes https://github.com/clangd/clangd/issues/1726
Fixes https://github.com/llvm/llvm-project/issues/64723
Fixes https://github.com/llvm/llvm-project/issues/64172

In addition, this patch also fixes an invalid test from D129499.

Reviewed By: erichkeane

Differential Revision: https://reviews.llvm.org/D158061