[all-commits] [llvm/llvm-project] ef8121: [Headers] Remove a space in NULL define

Heejin Ahn via All-commits all-commits at lists.llvm.org
Thu Aug 31 17:23:23 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef8121b109ef0be9fe94289acbfb9736d66cff15
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M clang/lib/Headers/__stddef_null.h

  Log Message:
  [Headers] Remove a space in NULL define

There was no space in `((void *)0)` before D158709. This can cause
downstream warnings in case other libraries define `NULL` as
`((void*)0)`, which is the case for [[ https://www.musl-libc.org/ | musl ]]. (see `NULL` definition in

When a macro is redefined, if the content is the same it is fine, but if
it is different even in terms of a single space, clang warns:
../musl/include/stdio.h:37:9: error: 'NULL' macro redefined [-Werror,-Wmacro-redefined]
   37 | #define NULL ((void*)0)
      |         ^

The old code didn't have the space and it had been fine for many years,
so I think there's no risk in removing it. The linter seems to prefer
the space in there, but I think it has a risk of causing warnings or
even errors for downstream users.

Reviewed By: iana

Differential Revision: https://reviews.llvm.org/D159312

More information about the All-commits mailing list