[all-commits] [llvm/llvm-project] 54d0cf: [TableGen] Remove & Replace old GICombiner Backend

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Thu Aug 31 04:16:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 54d0cf58fb5ecdcaab09779016b03e19b5646e9b
      https://github.com/llvm/llvm-project/commit/54d0cf58fb5ecdcaab09779016b03e19b5646e9b
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M llvm/docs/CommandGuide/tblgen.rst
    M llvm/lib/Target/AArch64/CMakeLists.txt
    M llvm/lib/Target/AMDGPU/CMakeLists.txt
    M llvm/lib/Target/Mips/CMakeLists.txt
    R llvm/test/TableGen/GICombinerEmitter/defs-invalid.td
    R llvm/test/TableGen/GICombinerEmitter/match-invalid.td
    R llvm/test/TableGen/GICombinerEmitter/match-tree.td
    R llvm/test/TableGen/GICombinerEmitter/parse-match-pattern.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-imms.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-operand-types.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-patfrag-root.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-permutations.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-variadics.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/match-table.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/operand-types.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/patfrag-errors.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/pattern-errors.td
    A llvm/test/TableGen/GlobalISelCombinerEmitter/pattern-parsing.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-imms.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-operand-types.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-patfrag-root.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-permutations.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-variadics.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/operand-types.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/patfrag-errors.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-errors.td
    R llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-parsing.td
    M llvm/utils/TableGen/CMakeLists.txt
    R llvm/utils/TableGen/GICombinerEmitter.cpp
    M llvm/utils/TableGen/GlobalISel/CMakeLists.txt
    R llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchDag.h
    R llvm/utils/TableGen/GlobalISel/GIMatchDagEdge.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchDagEdge.h
    R llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.h
    R llvm/utils/TableGen/GlobalISel/GIMatchDagOperands.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchDagOperands.h
    R llvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.h
    R llvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.h
    R llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp
    R llvm/utils/TableGen/GlobalISel/GIMatchTree.h
    A llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp
    R llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp
    M llvm/utils/gn/secondary/llvm/lib/Target/AArch64/BUILD.gn
    M llvm/utils/gn/secondary/llvm/lib/Target/AMDGPU/BUILD.gn
    M llvm/utils/gn/secondary/llvm/lib/Target/Mips/BUILD.gn
    M utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

  Log Message:
  -----------
  [TableGen] Remove & Replace old GICombiner Backend

The MatchTable-based GlobalISel Combiner backend is the new default. There are no in-tree users left of the old backend.

- Removed implementation of old MatchDAG-based Combiner, including tests, the backend itself and all supporting code.
- Renamed MatchTable backend to `GlobalISelCombinerEmitter.cpp` + removed "-matchtable" from its CL option.
    - no need to have a verbose name as it's the only backend left now.

Reviewed By: aemerson

Differential Revision: https://reviews.llvm.org/D158710




More information about the All-commits mailing list