[all-commits] [llvm/llvm-project] 6697af: [lldb][AArch64] Check SIMD save/restore in SVE SIM...

David Spickett via All-commits all-commits at lists.llvm.org
Thu Aug 31 02:22:08 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6697afe99fb6df08d4c1903eb1df5446f2ec1993
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M lldb/test/API/commands/register/register/aarch64_sve_simd_registers/TestSVESIMDRegisters.py
    M lldb/test/API/commands/register/register/aarch64_sve_simd_registers/main.c

  Log Message:
  [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

While doing some refactoring I forgot to carry over the copying in of
SIMD data in normal mode, but no tests failed.

Turns out, it's very easy for us to get the restore wrong because
even if you forget the memcopy, setting the buffer to valid may
just read the data you had before the expression evaluation.

So I've extended the SVE SIMD testing (which includes the plain SIMD mode)
to check expression save/restore. This is the only test that fails
if you forget to do `m_fpu_is_valid = true` so I take from that, that
prior to this it wasn't tested at all.

As a bonus, we now have coverage of the same thing for SVE and SSVE modes.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D157000

More information about the All-commits mailing list