[all-commits] [llvm/llvm-project] 9bd19b: [mlir][tensor] Fix bug in utility `tensor::isCastL...

Chris via All-commits all-commits at lists.llvm.org
Mon Aug 28 10:17:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9bd19bb703a437dfdac51823f26e25e0537d8c48
      https://github.com/llvm/llvm-project/commit/9bd19bb703a437dfdac51823f26e25e0537d8c48
  Author: Christopher Bate <cbate at nvidia.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/Tensor/Utils/Utils.h
    M mlir/lib/Dialect/Tensor/Utils/Utils.cpp
    M mlir/test/Dialect/Tensor/tracking-listener.mlir

  Log Message:
  -----------
  [mlir][tensor] Fix bug in utility `tensor::isCastLikeExtractSliceOp`

Fixes an issue where `isCastLikeExtractSliceOp` did not account for the fact
that `tensor.extract_slice` may drop non-unit dimensions. This change makes the
utility function behave inline with its name/description. The only user of this
function is in the `FindPayloadReplacementOpInterface` for the
`tensor::ExtractSliceOp`. This can potentially cause downstream projects to have
more "listener could not find replacement op" errors when interpreting Transform
IR, but the behavior is inline with the documented conservative behavior of the
Transform dialect's TrackingListener.

Reviewed By: springerm

Differential Revision: https://reviews.llvm.org/D158635




More information about the All-commits mailing list