[all-commits] [llvm/llvm-project] d4a912: Reland "[clang][modules] Use relative offsets for ...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Mon Aug 28 09:54:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4a912153488308ea9ab96a0267150460cdfc697
      https://github.com/llvm/llvm-project/commit/d4a912153488308ea9ab96a0267150460cdfc697
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M clang/include/clang/Serialization/ModuleFile.h
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp

  Log Message:
  -----------
  Reland "[clang][modules] Use relative offsets for input files"

This reverts commit 870f1583eed0f22ddfb1a1979a90198c3dc09927, effectively relanding commit b9d78bdc730b2fcfe029a7579c24020536c3fa25.


  Commit: 6fb08d8f558a6f28db7835acdb88cab83aea2eb4
      https://github.com/llvm/llvm-project/commit/6fb08d8f558a6f28db7835acdb88cab83aea2eb4
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M clang/include/clang/Basic/Module.h
    M clang/include/clang/Serialization/ASTBitCodes.h
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/GlobalModuleIndex.cpp
    M clang/test/Modules/ASTSignature.c
    A clang/test/Modules/diag-mappings-affecting.c

  Log Message:
  -----------
  Reland "[clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file"

This reverts commit b6ba804f7775f89f230ee1e62526a2f8225c7966, effectively relanding commit 7d1565727dad3acb54fe76a908630843835d7bc8.

The original commit incorrectly called `ASTWriter::writeUnhashedControlBlock()` before `ASTWriter::collectNonAffectingInputFiles()`, causing SourceLocations/FileIDs in the pragma diagnostic mappings block to be invalid. This is now tested by `clang/test/Modules/diag-mappings-affecting.c`.


  Commit: b9b81e37fe63d661afa356eacc97208ccc85da29
      https://github.com/llvm/llvm-project/commit/b9b81e37fe63d661afa356eacc97208ccc85da29
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  [clang][modules] NFC: Use local instead of `ModuleFile` member


Compare: https://github.com/llvm/llvm-project/compare/99fb0af80d16...b9b81e37fe63


More information about the All-commits mailing list