[all-commits] [llvm/llvm-project] 1880d8: [OpenMP][Archer] Add support for taskwait depend

Joachim via All-commits all-commits at lists.llvm.org
Mon Aug 28 00:43:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1880d8f5c15b796e3813bdc639982d985bf50824
      https://github.com/llvm/llvm-project/commit/1880d8f5c15b796e3813bdc639982d985bf50824
  Author: Joachim Jenke <jenke at itc.rwth-aachen.de>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M openmp/tools/archer/ompt-tsan.cpp
    A openmp/tools/archer/tests/races/taskwait-depend.c
    A openmp/tools/archer/tests/task/taskwait-depend.c

  Log Message:
  -----------
  [OpenMP][Archer] Add support for taskwait depend

At the moment Archer segfaults due to a null-pointer access, if an application
uses taskwait with depend clause as used in the two new tests.
This patch cleans up the task_schedule function, moves semantic blocks into
functions and replaces the if blocks by a single switch statement. The switch
statement will warn, when new enum values are added in OMPT and makes clear
what code is executed for the different cases.

With free-agent tasks coming up in OpenMP 6.0, we should expect more
null-pointer task_data, so additional null-pointer checks were added.
We also cannot rely on having an implicit task on the stack, so the
BarrierIndex is stored during task creation.

Differential Revision: https://reviews.llvm.org/D158072




More information about the All-commits mailing list