[all-commits] [llvm/llvm-project] ef70f5: Revert "Align mach exception data before accessing...

Jason Molenda via All-commits all-commits at lists.llvm.org
Fri Aug 18 15:34:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef70f5c6bbdadcaaeed6f028ed8eee8112b6543a
      https://github.com/llvm/llvm-project/commit/ef70f5c6bbdadcaaeed6f028ed8eee8112b6543a
  Author: Jason Molenda <jason at molenda.com>
  Date:   2023-08-18 (Fri, 18 Aug 2023)

  Changed paths:
    M lldb/tools/debugserver/source/MacOSX/MachException.cpp

  Log Message:
  -----------
  Revert "Align mach exception data before accessing it"

This reverts commit b10c2f846d936a98eecfcef1a90a754522282285.

Need to add the phabracator line to the message.


  Commit: 1a2122e9e9d1d495fdf337a4a9445b61ca56df6f
      https://github.com/llvm/llvm-project/commit/1a2122e9e9d1d495fdf337a4a9445b61ca56df6f
  Author: Jason Molenda <jason at molenda.com>
  Date:   2023-08-18 (Fri, 18 Aug 2023)

  Changed paths:
    M lldb/tools/debugserver/source/MacOSX/MachException.cpp

  Log Message:
  -----------
  Align mach exception data before accessing it

The mach exception data may not be doubleword aligned when we receive
it.  We use memcpy to align it later in this method when we save
the data, but for printing the value at the top, we need to do the
same or ubsan can trigger when LOG_EXCEPTIONS is enabled in
debugserver.

Differential Revision: https://reviews.llvm.org/D158312


Compare: https://github.com/llvm/llvm-project/compare/b10c2f846d93...1a2122e9e9d1


More information about the All-commits mailing list