[all-commits] [llvm/llvm-project] 2e4d2d: Reapply "[DebugInfo] Alternate (more efficient) MD...

Paul T Robinson via All-commits all-commits at lists.llvm.org
Fri Aug 18 05:24:25 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e4d2d800b9ce0924513a2f24e7a1f3d22b52383
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2023-08-18 (Fri, 18 Aug 2023)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/lib/CodeGen/CGDebugInfo.h
    M clang/test/CodeGenCXX/debug-info-function-context.cpp

  Log Message:
  Reapply "[DebugInfo] Alternate (more efficient) MD5 fix"

D155991 changed the file lookup to do a full string compare on the
filename; however, this added ~0.5% to compile time with -g.
Go back to the previous pointer-based lookup, but capture the main
file's checksum as well as its name to use when creating the extra
DIFile entry. This causes all entries to be consistent and also
avoids computing the checksum twice.

This reverts commit 21e7f73494663814e0296066895dfacdebfac6d4.
I'm unable to find a reason for the memory management issues
that caused the revert, so trying again.

More information about the All-commits mailing list