[all-commits] [llvm/llvm-project] 515c43: [asan] Fix stack pointers comparison in FakeStack

Vitaly Buka via All-commits all-commits at lists.llvm.org
Fri Aug 18 00:28:41 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 515c435e378b243b1be3da1587c9e206055f2c32
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2023-08-18 (Fri, 18 Aug 2023)

  Changed paths:
    M compiler-rt/lib/asan/asan_fake_stack.cpp

  Log Message:
  [asan] Fix stack pointers comparison in FakeStack

Unlucky naming top/bottom for stack bounds, has nothing to do with real
stack top. So top > botton is here, and opposite of
9be8892908d49c19fd6c9fc930d0f41276c3e345 assumption.

This is minimal fix in case cherry-picks is needed. Naming fix and
testing (if possible) will be in followup patches.

Introduced in 9be8892908d49c19fd6c9fc930d0f41276c3e345.
Can't symply reverted 9be8892908d49c19fd6c9fc930d0f41276c3e345 as
it fixes ~10 year old bug, accidentally exposed by

More information about the All-commits mailing list