[all-commits] [llvm/llvm-project] d37642: Simplify address mask setting logic in Addressable...

Jason Molenda via All-commits all-commits at lists.llvm.org
Thu Aug 17 16:24:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d37642b4a261b5b5687725fd60f7da5dc5ec4782
      https://github.com/llvm/llvm-project/commit/d37642b4a261b5b5687725fd60f7da5dc5ec4782
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M lldb/source/Utility/AddressableBits.cpp

  Log Message:
  -----------
  Simplify address mask setting logic in AddressableBits

I wrote some complicated conditionals for how to handle a partially
specified AddressableBits object in https://reviews.llvm.org/D158041 ,
and how to reuse existing masks if they were set and we had an
unspecified value.

I don't think this logic is the right thing to start
with.  Simplify back to the most straightforward
setting, where only the bits that have been specified
are set in the Process.




More information about the All-commits mailing list