[all-commits] [llvm/llvm-project] 12babb: [clang-tidy] Disable implicit search for a compila...

[Justin Bogner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12babb08189cc1ca84d7fbb33d3c9726583b2e5a
      https://github.com/llvm/llvm-project/commit/12babb08189cc1ca84d7fbb33d3c9726583b2e5a
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/checkers/cert/mem57-cpp-cpp17.cpp
    M clang-tools-extra/test/clang-tidy/checkers/readability/else-after-return-pp-no-crash.cpp
    M clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-case-violation.cpp
    M clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-multiple-TUs.cpp
    M clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp

  Log Message:
  -----------
  [clang-tidy] Disable implicit search for a compilation db in some tests

These tests were failing for me on windows with a very curious error:

  error: argument unused during compilation: '/Zc:preprocessor'

It turns out that they were walking up the directory structure and
finding the compilation DB in my top level llvm-project directory.

Add `--` to the ends of the clang-tidy command lines so that they
don't go looking for random compilation databases. Also replace args
specified with `-extra-arg` with directly specifying them to the
FixedCompilationDatabase.

Differential Revision: https://reviews.llvm.org/D158157