[all-commits] [llvm/llvm-project] 9460eb: [BOLT] Fix sorting functions by execution count

spupyrev via All-commits all-commits at lists.llvm.org
Wed Aug 16 15:08:37 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9460ebd13077feb164ea1687ce1d7c31000e8bef
  Author: spupyrev <spupyrev at fb.com>
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
    M bolt/lib/Passes/ReorderFunctions.cpp
    A bolt/test/X86/bug-function-layout-execount.s

  Log Message:
  [BOLT] Fix sorting functions by execution count

I noticed that `-reorder-functions=exec-count` doesn't work as expected due to
a bug in the comparison function (which isn't symmetric). It is questionable
whether anyone would want to ever use the sorting method (as sorting by say
density is much better in all cases) but it is probably better to fix the bug.

Reviewed By: Amir

Differential Revision: https://reviews.llvm.org/D152959

More information about the All-commits mailing list