[all-commits] [llvm/llvm-project] 83695d: [lldb][gui] Update TreeItem children's m_parent on...
Pavel Kosov via All-commits
all-commits at lists.llvm.org
Wed Aug 16 01:11:03 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 83695d45d62121ab306d0dc108b549d9056a2f28
https://github.com/llvm/llvm-project/commit/83695d45d62121ab306d0dc108b549d9056a2f28
Author: Pavel Kosov <kpdev42 at gmail.com>
Date: 2023-08-16 (Wed, 16 Aug 2023)
Changed paths:
M lldb/source/Core/IOHandlerCursesGUI.cpp
A lldb/test/API/commands/gui/spawn-threads/Makefile
A lldb/test/API/commands/gui/spawn-threads/TestGuiSpawnThreads.py
A lldb/test/API/commands/gui/spawn-threads/main.cpp
Log Message:
-----------
[lldb][gui] Update TreeItem children's m_parent on move
Before this patch, any time TreeItem is copied in Resize method, its
parent is not updated, which can cause crashes when, for example, thread
window with multiple hierarchy levels is updated. Makes TreeItem
move-only, removes TreeItem's m_delegate extra self-assignment by making
it a pointer, adds code to fix up children's parent on move constructor
and operator=
Patch prepared by NH5pml30
~~~
Huawei RRI, OS Lab
Reviewed By: clayborg
Differential Revision: https://reviews.llvm.org/D157960
More information about the All-commits
mailing list