[all-commits] [llvm/llvm-project] 490a86: [GlobalISel] Also set dead flags of implicit defs ...

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Thu Aug 10 23:38:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 490a867f16c064b774aeae9661dc699a65909ce2
      https://github.com/llvm/llvm-project/commit/490a867f16c064b774aeae9661dc699a65909ce2
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2023-08-11 (Fri, 11 Aug 2023)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h
    M llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
    M llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-swap-compare-operands.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/select-arith-extended-reg.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/select-arith-shifted-reg.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/select-binop.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/select-jump-table-brjt.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/select-ptr-add.mir
    M llvm/test/CodeGen/AArch64/GlobalISel/sext-inreg-ldrow-16b.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-abs.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-anyext.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-build-vector-trunc.v2s16.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fabs.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fneg.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-select.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-sext.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-zext.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-ashr-scalar.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-blsi.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-blsr.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-brcond.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-cmp.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-constant.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-leaf-constant.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-lshr-scalar.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-phi.mir
    M llvm/test/CodeGen/X86/GlobalISel/select-shl-scalar.mir
    M llvm/test/CodeGen/X86/GlobalISel/x86_64-select-zext.mir
    M llvm/test/CodeGen/X86/switch-bit-test-unreachable-default.ll
    M llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/x86-condbr.mir.expected
    M llvm/utils/TableGen/GlobalISelMatchTable.cpp

  Log Message:
  -----------
  [GlobalISel] Also set dead flags of implicit defs added by BuildMI

BuildMI automatically adds the implicit operands of the
instruction. This meant we couldn''t set the dead flag on
dead implicit defs in that case.

Fix it by introducing an opcode to mark a given implicit
def as dead.

Fixes #64565

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D157515




More information about the All-commits mailing list