[all-commits] [llvm/llvm-project] 487ab3: [lldb][test] Remove tests relying on deprecated st...

Michael Buch via All-commits all-commits at lists.llvm.org
Thu Aug 10 11:49:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 487ab39a5082098f92e886de606505f25031a22a
      https://github.com/llvm/llvm-project/commit/487ab39a5082098f92e886de606505f25031a22a
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/TestDataFormatterStdString.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/main.cpp

  Log Message:
  -----------
  [lldb][test] Remove tests relying on deprecated std::char_traits specializations

(motivated by test failures after D157058)

With D157058 the base template for `std::char_traits` was removed from
libc++. Quoting the release notes:

```
The base template for ``std::char_traits`` has been removed. If you are using
``std::char_traits`` with types other than ``char``, ``wchar_t``, ``char8_t``,
``char16_t``, ``char32_t`` or a custom character type for which you
specialized ``std::char_traits``, your code will no longer work.
```

This patch simply removes all such instantiations to make sure the
tests that run against the latest libc++ version pass.

One could try testing the existence of this base template from within
the test source files but this doesn't seem like something we want
support.

Differential Revision: https://reviews.llvm.org/D157636




More information about the All-commits mailing list