[all-commits] [llvm/llvm-project] 280d68: [libc++] Clean up mess around __throw_runtime_error

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Aug 10 05:31:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 280d68e7f808af74ca48cfeb849e6ac910f96e5c
      https://github.com/llvm/llvm-project/commit/280d68e7f808af74ca48cfeb849e6ac910f96e5c
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M libcxx/src/locale.cpp
    M libcxx/src/stdexcept.cpp
    M libcxx/utils/data/ignore_format.txt

  Log Message:
  -----------
  [libc++] Clean up mess around __throw_runtime_error

We were defining the function in locale.cpp, and we actually had two
overloads for it. This is pretty confusing given that one was static
and not exported from the dylib, and the other one was. Instead, use
the vanilla __throw_runtime_error function everywhere even though that
adds a tiny bit of code duplication.

Differential Revision: https://reviews.llvm.org/D155008




More information about the All-commits mailing list