[all-commits] [llvm/llvm-project] bdd17b: Remove a reference to rdar://problem/10664933
Jon Roelofs via All-commits
all-commits at lists.llvm.org
Wed Aug 9 15:13:36 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: bdd17b853fac85c6542318a7fa0382f241869a57
https://github.com/llvm/llvm-project/commit/bdd17b853fac85c6542318a7fa0382f241869a57
Author: Jon Roelofs <jonathan_roelofs at apple.com>
Date: 2023-08-09 (Wed, 09 Aug 2023)
Changed paths:
M llvm/lib/CodeGen/SplitKit.cpp
Log Message:
-----------
Remove a reference to rdar://problem/10664933
The original commit, and the comments in the code already provide sufficient
context. But for posterity, there's a tiny bit more that might be useful if
someone is digging here in the future:
> This is related to <rdar://problem/10318439> Lower invokes into terminating
> machine instructions.
>
> The return value from a function call is live in to that function call's
> landing pad. The landing pad is shared with a later call, and the variable is
> undef on the first exceptional edge.
>
> Our computation of the last legal split point gets confused because the
> return value is live-out from the calling block, and live-in to the landing
> pad, but it is not live on the edge itself.
>
> Fixed in r147911 and r147912.
More information about the All-commits
mailing list