[all-commits] [llvm/llvm-project] bbce1f: [mlir] Fix verifier for call debug locations

[Valentin Clement (バレンタイン クレメン) via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bbce1fcbaa2768328816a01e680710d06e441828
      https://github.com/llvm/llvm-project/commit/bbce1fcbaa2768328816a01e680710d06e441828
  Author: Valentin Clement <clementval at gmail.com>
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    A mlir/test/Dialect/LLVMIR/call-location.mlir

  Log Message:
  -----------
  [mlir] Fix verifier for call debug locations

D157096 introduces a new verifier for debug location
on call operation. `isDeclaration()` is actually not defined
for `LLVMFuncOp` and default to the interface definition that always
return `false`. This leads to wrong diagnostic in some case as shown in the added test.
Use `callee.isExternal()` instead that returns the
desired information.

We have seen this error being triggered during flang codegen.

Reviewed By: Dinistro, vzakhari

Differential Revision: https://reviews.llvm.org/D157447