[all-commits] [llvm/llvm-project] 0a315b: [include-cleaner] Dont boost private headers beyon...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Wed Aug 9 00:37:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0a315be2a46f35bb990dd6c8418a189daec15350
      https://github.com/llvm/llvm-project/commit/0a315be2a46f35bb990dd6c8418a189daec15350
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
    M clang-tools-extra/include-cleaner/lib/TypesInternal.h
    M clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
    M clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp

  Log Message:
  -----------
  [include-cleaner] Dont boost private headers beyond public ones

Private headers should be the last resort, even if they match the name
of a symbol. It's pretty common in umrella headers to have internal file names
that match the symbol (e.g. Eigen::Matrix, declared in private header Matrix.h,
and exposed in umbrella header Eigen/Core).

Differential Revision: https://reviews.llvm.org/D157400




More information about the All-commits mailing list