[all-commits] [llvm/llvm-project] 24c91d: [clang][ExprConstant] Fix crash on uninitialized b...

[Takuya Shimizu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 24c91d443222bdb20205630d300ae61bfa07067e
      https://github.com/llvm/llvm-project/commit/24c91d443222bdb20205630d300ae61bfa07067e
  Author: Takuya Shimizu <shimizu2486 at gmail.com>
  Date:   2023-08-08 (Tue, 08 Aug 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Basic/DiagnosticASTKinds.td
    M clang/lib/AST/ExprConstant.cpp
    A clang/test/Misc/constexpr-subobj-init-source-ranges.cpp
    A clang/test/SemaCXX/constexpr-subobj-initialization.cpp

  Log Message:
  -----------
  [clang][ExprConstant] Fix crash on uninitialized base class subobject

This patch fixes the reported regression caused by D146358 through adding notes about an uninitialized base class when we diagnose uninitialized constructor.

This also changes the wording from the old one in order to make it clear that the uninitialized subobject is a base class and its constructor is not called.
Wording changes:
BEFORE: `subobject of type 'Base' is not initialized`
AFTER: `constructor of base class 'Base' is not called`

Fixes https://github.com/llvm/llvm-project/issues/63496

Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D153969