[all-commits] [llvm/llvm-project] b0f4b6: AMDGPU: Delete probably wrong constant folding of ...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Fri Aug 4 18:01:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b0f4b6587a8e1044f6e4e1e117cc166586678ee5
      https://github.com/llvm/llvm-project/commit/b0f4b6587a8e1044f6e4e1e117cc166586678ee5
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp

  Log Message:
  -----------
  AMDGPU: Delete probably wrong constant folding of expm1

It's not really correct to implement this as exp(x) - 1, it was maybe
OK for the restricted float-as-double case handled here. There's not a
strong reason to special case it with the host function, as the
implementation naturally constant folds anyway. InstSimplify can fully
handle everything in it, so just running the inliner alone with a
constant argument produces the fully constant folded result. This also
had no tests.

https://reviews.llvm.org/D156892




More information about the All-commits mailing list