[all-commits] [llvm/llvm-project] e21b1d: [clang][CFG] Fix 2 memory errors in interval compu...

Yitzhak Mandelbaum via All-commits all-commits at lists.llvm.org
Fri Aug 4 14:11:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e21b1dd9cc5316c00216ba54f899f67fe473ab33
      https://github.com/llvm/llvm-project/commit/e21b1dd9cc5316c00216ba54f899f67fe473ab33
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M clang/lib/Analysis/IntervalPartition.cpp
    M clang/unittests/Analysis/IntervalPartitionTest.cpp

  Log Message:
  -----------
  [clang][CFG] Fix 2 memory errors in interval computation.

This fixes 2 bugs and adds corresponding tests. Both related to unreachable
blocks. One occured in the `WTOCompare` construction, which assumed the size of
the order was the same as the number of blocks in the CFG, which isn't true when
some blocks are unreachable.  The other assumed predecessor pointers were
non-null, which can be false for blocks with unreachable predecessors.

Differential Revision: https://reviews.llvm.org/D157033




More information about the All-commits mailing list