[all-commits] [llvm/llvm-project] 786bab: Display PC instead of <unknown> for stack trace in...

[Zhenyu Tom Yang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 786bab43346939d5662c2a90f8c0ff72fe421614
      https://github.com/llvm/llvm-project/commit/786bab43346939d5662c2a90f8c0ff72fe421614
  Author: Tom Yang <toyang at fb.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    A lldb/test/API/tools/lldb-vscode/stackTraceMissingFunctionName/Makefile
    A lldb/test/API/tools/lldb-vscode/stackTraceMissingFunctionName/TestVSCode_stackTraceMissingFunctionName.py
    A lldb/test/API/tools/lldb-vscode/stackTraceMissingFunctionName/main.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp

  Log Message:
  -----------
  Display PC instead of <unknown> for stack trace in vscode

It isn't useful for users to see "<unknown>" as a stack trace when lldb fails to symbolicate a stack frame. I've replaced "<unknown>" with the value of the program counter instead.

Test Plan:

To test this, I opened a target that lldb fails to symbolicate in
VSCode, and observed in the CALL STACK section that instead of being
shown as "<unknown>", those stack frames are represented by their
program counters.

I added a new test case, `TestVSCode_stackTraceMissingFunctionName` that
exercises this feature.

I also ran `lldb-dotest -p TestVSCode` and saw that the tests passed.

Differential Revision: https://reviews.llvm.org/D156732